search

themsaid / ibis

A PHP tool that helps you write eBooks in markdown and convert to PDF.
MIT License
1.97k stars 150 forks source link

Upgrade PHP 8.2 and packages #57

Open roberto-butti opened 1 year ago

roberto-butti commented 1 year ago
dcblogdev commented 1 year ago

would be great to get this merged.

edwinheij commented 1 year ago
  • upgrade and check with PHP 8.2
  • upgrade code using new renderer of Commonmark
  • upgrade GitHub Actions workflow
  • using Pint with PSR12
  • added configuration for cover image (instead of using hardcoded cover.jpg, you can specify a new file name and format, for example, my-cover.png)

And adds support for Laravel v10

Can this be merged?

sajaddp commented 1 year ago

@themsaid Can you please merge it?

roberto-butti commented 1 year ago

Good morning Mohamed @themsaid . I know you are super busy, and this project is great and very helpful. I would like to know if you have any plans to upgrade this wonderful project with the latest packages. I would like to understand how I can be of support or help (if necessary) in the maintenance of this project.

Thank you! 🙏

Roberto

bobbyiliev commented 1 year ago

Good morning Mohamed @themsaid . I know you are super busy, and this project is great and very helpful. I would like to know if you have any plans to upgrade this wonderful project with the latest packages. I would like to understand how I can be of support or help (if necessary) in the maintenance of this project.

Thank you! 🙏

Roberto

I would love to offer my help as well! I love the tool, it has allowed me to publish 5+ books so far 🙏

image
dcblogdev commented 1 year ago

@roberto-butti can you release your fork? It would be amazing to have an installable version.

CyberMullah commented 1 year ago

@themsaid Any plan to have a quick review of this PR and merge. Thanks

roberto-butti commented 1 year ago

I'm available to publish the package from the forked repo, but i think is better and fair to wait Mohamed.

tnylea commented 1 year ago

In case someone wants to use the version that @roberto-butti

I've added a temporary working version here: https://github.com/thedevdojo/ibis

You can install with: composer global require thedevdojo/ibis

I will remove this package when it's no longer necessary and this gets merged in, but until then, you can use this version with the latest version of Laravel 😉

CyberMullah commented 1 year ago

Thank you @tnylea, Let's hope @themsaid sees the comments and merges the PR. :)

roberto-butti commented 11 months ago

Hi Folks, on top of this PR, i created the PHP8.3 Pull request. Based on the PHP 8.2 changes, PHP 8.3 doesn't introduce changes; just adjusted the GitHub Workflow for the CI just to check the PHP8.3 execution https://github.com/themsaid/ibis/pull/58