themyth92 / angular2-lightbox

Lightbox2 port to use with angular2
MIT License
32 stars 18 forks source link

Allow caption to use with html #52

Closed themyth92 closed 6 years ago

themyth92 commented 6 years ago

Fix #51

stephanrauh commented 6 years ago

Does this approach work? In theory, it shouldn't, as stated here: https://stackoverflow.com/questions/46217049/angular-2-how-can-i-apply-directives-to-sanitized-html-innerhtml

In any case, please make bypassing the DOM sanitizer an option that's deactivated by default. Otherwise, developers might run into security issues without being aware of the danger.