search

themyth92 / ngx-lightbox

Lightbox2 use with angular >= 5
MIT License
115 stars 70 forks source link

(peer)depedency now missing from the package.json? #106

Open jcompagner opened 3 years ago

jcompagner commented 3 years ago

With the new release 2.5.0 we suddenly have:

An error occurred during the build: Error: The target entry-point "ngx-lightbox" has missing dependencies:

because of the pull:

https://github.com/themyth92/ngx-lightbox/pull/103/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519R28

I know i can fix this by also including that one in our build, but that is a bit annoying, currently our builds are broken because of the above thing if we just install 2.5.0 version of lightbox.

jcompagner commented 3 years ago

and if you then just install ngx-filesaver you get:

✖ Compiling with Angular sources in Ivy partial compilation mode. node_modules/ngx-filesaver/src/filesaver.service.d.ts:1:34 - error TS2307: Cannot find module 'file-saver' or its corresponding type declarations.

1 import { FileSaverOptions } from 'file-saver';

node_modules/ngx-filesaver/src/filesaver.directive.d.ts:4:34 - error TS2307: Cannot find module 'file-saver' or its corresponding type declarations.

4 import { FileSaverOptions } from 'file-saver';
themyth92 commented 3 years ago

Sorry can u try to install file-saver and ngx-filesaver first. I will need to add both to the peer-denpendancy later

themyth92 commented 3 years ago

Or just use 2.4.1 for now. That version is fine.