Angular 8 compiler error

themyth92 / ngx-lightbox

Lightbox2 use with angular >= 5

MIT License

115 stars 70 forks source link

Angular 8 compiler error #21

Closed editter closed 5 years ago

editter commented 5 years ago

I updated to Angular 8 and ngx-lightbox started to throw errors during runtime (build seemed fine), prior to that everything worked great.

From what I can tell its related to lightbox.service.ts but I am not 100% sure. The attached image shows the error in the browser

agyonov commented 5 years ago

A new version of ngx-lightbox is needed, as with Angular 8, they have move DOCUMENT from '@angular/platform-browser' to '@angular/common'.

BTW ng update shall do it automatically, when ngx-lightbox project is updated/upgraded...

rostalevicek commented 5 years ago

I have the same error. I installed ngx-lightbox@latest into existing Angular 8 project and it throws exactly the same error. Can you help me please? Thanks!

chintanttm commented 5 years ago

I am having the same error after updating my project to Angular 8.

Is there any solution for this?

BlackfootPL commented 5 years ago

I've created PR for that...

themyth92 commented 5 years ago

Hi, thank @BlackfootPL a lot for your PR. I am very busy nowadays. Will review and merge ASAP

themyth92 commented 5 years ago

@BlackfootPL got some error when try to run locally. Not sure what is happening.

npm start is the command i run

themyth92 commented 5 years ago

Nvm, need to remove node_modules and run yarn again. I will publish new version soon.

themyth92 commented 5 years ago

V2.0.0 has been published to support angular8. Tks to @BlackfootPL