search

themyth92 / ngx-lightbox

Lightbox2 use with angular >= 5
MIT License
115 stars 66 forks source link

upgrade to Angular8, refactor to library-project, replace gifs with svgs #24

Closed flobacher closed 3 years ago

themyth92 commented 5 years ago

Hey, thanks a lot for your PR. Can you merge my master and fix conflict. Also my master already got the upgrade for Angular8 but we can keep the refractor and replace gif with SVG.

Anw thanks a lot.

flobacher commented 5 years ago

yeah.. cool! I only saw after I made the PR that it was already upgraded in the meantime.. will update my pr... thanks!

flobacher commented 5 years ago

@themyth92 I resolved all conflicts and updated my pr. the travis ci build failed, because when working with a library project, the default way to do publish, seems to go to the dist/ngx-buildplus folder (contains its own package.json) and call npm publish from there. I pointed that out in the publish script of the root package.json and return an error there thats the build error from travis..

themyth92 commented 5 years ago

Hi, any reasons why you move all the files inside demo folder into demo/src folder ?

flobacher commented 5 years ago

Hi, any reasons why you move all the files inside demo folder into demo/src folder ?

I just added the demo as a standard application project via the angular/cli.. thats their standard setup..

themyth92 commented 5 years ago

seems to go to the dist/ngx-buildplus folder (contains its own package.json) and call npm publish from there

Travis does not do any publish. I think you have to use this file instead https://github.com/themyth92/ngx-lightbox/blob/master/.travis.yml

themyth92 commented 5 years ago

Hi there, really glad that you submit the PR. However, the PR is too big and refractor a lot of stuff. I think it is better not to change the structure of the project I am building but focus on small thing. Like the conversion from GIF to SVG is great and only submit the PR for that. Really appreciate your work though.