search

themyth92 / ngx-lightbox

Lightbox2 use with angular >= 5
MIT License
115 stars 70 forks source link

lb-disable-scrolling class not removed from html when modal is closed. #39

Closed aircliff01 closed 5 years ago

aircliff01 commented 5 years ago

In the lightbox config when i set lightboxConfig.disableScrolling = true and i open a photo, it works as expected, theres no scrolling whatsoever and the html tag has a class lb-disable-scrolling which has overflow:hiidden.

The issue is when i close the modal, it doesnt remove the lb-disable-scrolling, so i cannot scroll on the page anymore. If i manually remove the lb-disable-scrolling it works fine for me.

I tested this with angular v8.0.0 and ngx-lightbox version 2.1.0

themyth92 commented 5 years ago

Should be fixed with version 2.1.1, thanks @Aircliff for reporting