Why Lightbox overlay is calculating max height instead using viewport?

themyth92 / ngx-lightbox

Lightbox2 use with angular >= 5

MIT License

115 stars 70 forks source link

Why Lightbox overlay is calculating max height instead using viewport? #56

Open miqm opened 4 years ago

miqm commented 4 years ago

Hi,

I used this component in my project, but when I open lightbox, it shows me a scrollbar on the overlay even if image is quite small.

I noticed, that to get overlay height you use Math.Max function. However, if one of site's component has a quite long list, it will make the overlay as big as the list.

My question is - why not use 100vh/100vw styles?

Asimov500 commented 2 years ago

Yes I am having this problem also. Can I edit the css directly?