search

themyth92 / ngx-lightbox

Lightbox2 use with angular >= 5
MIT License
115 stars 70 forks source link

add showDelete config and optional delete button #70

Closed bwinchester closed 4 years ago

bwinchester commented 4 years ago

This adds an optional delete button, as well as a delete event that passes the deleted url in the event.data object argument

themyth92 commented 4 years ago

Hi @bwinchester what is this deleted button used for ?

bwinchester commented 4 years ago

Hi @themyth92, yeah, so it adds a delete button to the bottom area of the image, just as rotate does, that fires a delete event for the users of the lightbox to optionally allow users to fire delete image events.

themyth92 commented 4 years ago

Yeah but why user need this delete button ? I dont see the use case here. I think this feature maybe more like selected image button make more sense. User can then do whatever they want with that (delete, send a request, ...) but then i think it is complicated (optional icon change, text change for that button to fit the use case ...).

bwinchester commented 4 years ago

Is there a selected image button?

On Thu, Oct 1, 2020 at 9:49 PM themyth92 notifications@github.com wrote:

Yeah but why user need this delete button ? I dont see the use case here.

I think this feature maybe more like selected image button make more sense. User can then do whatever they want with that (delete, send a request, ...) but then i think it is complicated (optional icon change, text change for that button to fit the use case ...).

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/themyth92/ngx-lightbox/pull/70#issuecomment-702498329, or unsubscribe https://github.com/notifications/unsubscribe-auth/AASDYZMFEIUNFSVFWSIJPRDSIU5T5ANCNFSM4R7QEOKQ .

themyth92 commented 4 years ago

There is no selected button at the moment

bwinchester commented 4 years ago

Im closing this PR, I was just trying to follow the pattern of adding buttons in the row of buttons for a feature we needed, which seems useful.

We ended up just writing our own shadow box component to suit our needs.