search

then / is-promise

Test whether an object looks like a promises-a+ promise
MIT License
282 stars 32 forks source link

Always return a boolean value #3

Closed nhunzaker closed 9 years ago

nhunzaker commented 9 years ago

I hit a snag writing isPromise(undefinedThing) === false, so I added a double-bang to the initial check to ensure that a boolean value is always returned.

edef1c commented 9 years ago

Landed! @ForbesLindesay, could you please npm publish v2.1.0? I've tagged it and everything, but I don't have publish access.

nhunzaker commented 9 years ago

Thanks! On Jun 30, 2015 8:37 AM, "Nathan Zadoks" notifications@github.com wrote:

Closed #3 https://github.com/then/is-promise/pull/3 via ed0eaa4 https://github.com/then/is-promise/commit/ed0eaa4dec17597f0dae892a0472a9b7f459320d .

— Reply to this email directly or view it on GitHub https://github.com/then/is-promise/pull/3#event-344159706.

nhunzaker commented 9 years ago

Any news here? I'd love to have this!

ForbesLindesay commented 9 years ago

Published, and I've added @nathan7 as an owner on npm to make future publishing easier.

nhunzaker commented 9 years ago

Thanks!