feat: add typescript definitions

then / is-promise

Test whether an object looks like a promises-a+ promise

MIT License

282 stars 32 forks source link

feat: add typescript definitions #31

Closed ForbesLindesay closed 4 years ago

rollingversions[bot] commented 4 years ago

Change Log for is-promise (2.2.2 → 3.0.0)

Breaking Changes

This package now comes bundled with TypeScript definitions

This means you may get new errors that you didn't see before if you are using TypeScript. If you are not using TypeScript, this change will not impact you.

Edit changelog

ForbesLindesay commented 4 years ago

@mvila would you be able to give this a quick look to sanity check what I've done? As with all these small libraries, it feels like 90% of the work is writing the tests.

LarryBattle commented 4 years ago

Even though it might be redundant, could you add a test for Promise.resolve()?

assert(isPromise(Promise.resolve()) === true);

mvila commented 4 years ago

Thanks, @ForbesLindesay! It all sounds good to me.