promise.race() missing from the API description in README

then / promise

Bare bones Promises/A+ implementation

https://www.promisejs.org

MIT License

2.58k stars 312 forks source link

promise.race() missing from the API description in README #154

Closed debopamsengupta closed 5 years ago

debopamsengupta commented 5 years ago

~~Currently ran into an issue in a project where using this library resulted in errors on Internet Explorer and took me a while to find out that the reason was Promise.race() wasn't supported.~~

~~Would be nice to add this method to the library since Promise.race() is natively defined in ES6 :)~~

~~Happy to make a PR for this if that's alright !~~

Ignore me ! Just missing in the README :)

ForbesLindesay commented 5 years ago

https://github.com/then/promise/blob/master/src/es6-extensions.js#L95-L101

debopamsengupta commented 5 years ago

@ForbesLindesay indeed ! I didn't spot race() in the documentation in the README and assumed it didn't exist :D

shall I add it there ?

ForbesLindesay commented 5 years ago

That would be good. The proper reference docs are at https://www.promisejs.org/api/

debopamsengupta commented 5 years ago

fixed in #155