search

thenativeweb / node-cqrs-domain

Node-cqrs-domain is a node.js module based on nodeEventStore that. It can be very useful as domain component if you work with (d)ddd, cqrs, eventdenormalizer, host, etc.
http://cqrs.js.org/pages/domain.html
MIT License
269 stars 57 forks source link

Command revision verifying while disabled persistance #112

Closed repkins closed 6 years ago

repkins commented 6 years ago

Hello, @adrai!

I have noticed a potential bug about how default command handler verifies command revision with associated aggregate. While aggregate has disabled persistence using definition property disablePersistence: true, I don't think it should verify revision of incoming command with such aggregate because there is no stored previous events to build aggregate from them so far.

adrai commented 6 years ago

So would you suggest to not verify the revision when disablePersistence is set to true, right?

adrai commented 6 years ago

v2.9.8

repkins commented 6 years ago

Yap, i would suggest. :-)