search

thenativeweb / node-cqrs-domain

Node-cqrs-domain is a node.js module based on nodeEventStore that. It can be very useful as domain component if you work with (d)ddd, cqrs, eventdenormalizer, host, etc.
http://cqrs.js.org/pages/domain.html
MIT License
269 stars 57 forks source link

Add google cloud datastore Lock implementation #135

Open amura2406 opened 5 years ago

amura2406 commented 5 years ago

Hi, I just added google cloud datastore implementation, I use it on my project Just thought that you want to include it in your original repo.

Thanks

adrai commented 5 years ago

Can index.yaml be moved somewhere else? i.e. test directory?

amura2406 commented 5 years ago

yes, certainly

amura2406 commented 5 years ago

already move the file to test folder

adrai commented 5 years ago

Can you also extend the readme?

adrai commented 5 years ago

btw: Can you please use the use function Lock.use instead of require (like the other db implementations)?

amura2406 commented 5 years ago

done

adrai commented 5 years ago

Is the datastore “testable” via travis or should we skip it in the tests?

nanov commented 5 years ago

It should be. Might take a deeper look later on today.

amura2406 commented 5 years ago

I think so too, but I haven't got lucky with cloud datastore emulator in the past few days

adrai commented 5 years ago

else it should be skipped here