search

thenativeweb / node-cqrs-domain

Node-cqrs-domain is a node.js module based on nodeEventStore that. It can be very useful as domain component if you work with (d)ddd, cqrs, eventdenormalizer, host, etc.
http://cqrs.js.org/pages/domain.html
MIT License
269 stars 57 forks source link

Adding SRV support for MongoDB #150

Closed Glockenbeat closed 5 years ago

Glockenbeat commented 5 years ago

This will enable MongoDB Atlas mongodb+srv:// URLs to be used without specifying the single servers, therefore being able to change and scale any MongoDB cluster without affecting any client.

Glockenbeat commented 5 years ago

Guess Node 0.10 doesn't really matter, does it?

nanov commented 5 years ago

Well it does, but the error comes from a completely different place ( aws-sdk ), how did the tests pass up until now? I mean you have changed nothing in the aws-sdk setup in this commit.

adrai commented 5 years ago

It’s because of >=

Perhaps aws-sdk dropped compatibility?

adrai commented 5 years ago

Btw. Can’t this be achieved by simply setting the options.url ?

nanov commented 5 years ago

@adrai seems the only difference is the +srv on the protocol side, as such it should be totally achievable with url option.

Glockenbeat commented 5 years ago

Holy smokes, I didn't see the url option up until now, although it was right in my face. Just tested, works fine with that if I set the full URL myself. Another difference is that the MongoClient won't accept a port though and will throw, but that is fine when setting the url myself.

Closing the request as it is not needed at all. Sorry for wasting your time.