search

thenativeweb / node-eventstore

EventStore Implementation in node.js
http://eventstore.js.org/
MIT License
538 stars 117 forks source link

Feature/emit eventstore events #149

Closed bobbytes closed 5 years ago

bobbytes commented 5 years ago

Emit nodejs events before and after an eventstore event including timestamp.

nanov commented 5 years ago

Hi @DaNautilus it seems you have done a pretty good job encapsulating this functionally into a separated module that wraps each the original store implementation.

Is there a real need for that to be enabled by default ( ie lines 75,76 in index.js ), and for it to be a part from this library? What is the exact use case of this?

nanov commented 5 years ago

I am waiting for the comments of @DaNautilus before taking further actions. Without going into implementation details, i would leave this as optional add-on ( still can be a part of the library ) instead of enabling it by default.

bobbytes commented 5 years ago

@nanov To support out maintenance we'd like to measure database events. Our cloud provider does not provide any database metrics and that's why we have to do it manually.

@adrai did it already for our denormalizers in node-viewmodel. But unfortunately we miss this feature for our eventstore.

And yes, you're right, there's no need to enable it by default. I'm going to implement a solution for that.

nanov commented 5 years ago

Great!

I am going to review, merge and release this later on today!

nanov commented 5 years ago

Landed in v1.15.0.

bobbytes commented 5 years ago

Great, thanks a lot 👍🏻 🎉