search

thencc / algonautjs

A front end friendly Algorand utility
MIT License
10 stars 1 forks source link

upgraded inkey-client-js dep #86

Closed enceladus closed 1 year ago

enceladus commented 1 year ago

Upgrade inkey-client-js to version 0.0.24 and any-wallet to 0.1.82

Should be merged AFTER inkey-client-js, inkey-types, inkey-wallet, and most importantly, any-wallet

spencercap commented 1 year ago

yeah – this should merged after those other 2 PRs 👍

also, seems this build is failing because there isnt an up-to-date pnpm lock file which raises the question.... should NCC use npm or pnpm? personally i use pnpm because it's faster (because symlinks / aliasing) and i can install on a repo w/out internet on occasion. github actions can be setup for either. this is all related to the staging/prod / CI / repo branches convo that seems to be halfway resolved and less than half implemented imo

spencercap commented 1 year ago

just need to fix tests and then ok to merge