thenewboston-blockchain / Developer-Portal

Developer portal for thenewboston.
https://developer.thenewboston.com/
MIT License
24 stars 9 forks source link

Set new sample values in validator deployment guide #80

Closed FrostMegaByte closed 2 years ago

FrostMegaByte commented 2 years ago

This PR is just for 2 minor things I've noticed whilst setting up a CV which gave me a bit of confusion. This PR can prevent duplicate questions like mine in Discord.

The default sample value is currently PRIMARY_VALIDATOR. This value will most likely result in people using this default value and thus setting up new PVs. (This is what I wanted to do first) However, according to @hussu010 "Setting a new PV will mean you're trying to host your own version of TNBC chain." And I'm pretty sure, that most people don't actually want to host their own version, but just want to expand upon the current chain. Therefore changing the default value to CONFIRMATION_VALIDATOR seems more logical to me.

Furthermore, the https://gist.githubusercontent.com/buckyroberts/519b5cb82a0a5b5d4ae8a2175b722520/raw/9237deb449e27cab93cb89ea3346ecdfc61fe9ea/0.json default value for the root account file doesn't work as it will throw an exception related to expecting an integer, but receiving a double. The suggested root_account_file.json file is now from Bucky's PV.

If applicable, this is my account number: 4114626f5c783311cfe7a6b88b7bc4a9135c6b1310009dcca5cf36d2395f8814