search

thenewboston-blockchain / Kotlin-SDK

Kotlin-SDK for thenewboston.
https://thenewboston.com
MIT License
42 stars 19 forks source link

Implement GET request for Banks endpoint in Confirmation Validator #129

Closed IanArb closed 3 years ago

IanArb commented 3 years ago

AS an SDK user and confirmation validator I WANT to see all the banks on the network SO THAT I can maintain a record of all connected banks.

Description Implement GET requests in GetDataSource and expose the function in ConfirmationDataSource layer and then expose to the ConfirmationRepository.

Please write unit tests to cover cases.

**Note: If you can see where we can reuse some data models, please consider doing that. In this case, we can reuse the Bank data class.

Documentation - https://thenewboston.com/confirmation-validator-api/banks

IanArb commented 3 years ago

Hey @nishp77 any progress on this?

warmachinesocial commented 3 years ago

I'm done with it? Plus you merged the PR, is there anything left?

IanArb commented 3 years ago

I see the PR was merged but it didn't close this issue. Thanks!