search

thenewboston-blockchain / Kotlin-SDK

Kotlin-SDK for thenewboston.
https://thenewboston.com
MIT License
42 stars 19 forks source link

Done with GetBanks for CV #144

Closed warmachinesocial closed 3 years ago

warmachinesocial commented 3 years ago

Solves #129, @Ian I had a question on if we could have the dto to be reused as I have done in this case or do we create a new dto? please check that out

IanArb commented 3 years ago

Hey @nishp77 looks good. Can we fix the conflicts please.

sonarcloud[bot] commented 3 years ago

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

70.0% 70.0% Coverage
0.0% 0.0% Duplication

IanArb commented 3 years ago

@nishp77 Approved and merged.

Just a pro tip: Opening multiple PRs at the same time will create conflicts in each PR. This just creates more work for yourself and I recommend doing one task at a time.