thenewboston-blockchain / thenewboston-js

JavaScript library for thenewboston.
https://www.npmjs.com/package/thenewboston
MIT License
37 stars 18 forks source link

Tests times out due to connection to external APIs #150

Open dras51 opened 3 years ago

dras51 commented 3 years ago

Payment Handler test fails due to some sort of connection to an external API not returning a response before the test times out A clear and concise description of what the bug is.

To Reproduce Steps to reproduce the behavior:

this is a sneaky bug and so it doesn't happen all the time, except if the connection to the external API is slow, how ever you can confirm that the test isn't running locally by turning off your internet connection and

  1. Turn off your internet connection
  2. Go to 'Terminal' in the root folder
  3. run 'npm run test'
  4. Scroll down 'on your console'
  5. See error

Expected behavior Tests should run fine when its not connected to the internet as the data required from external sources should be mocked

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

Additional context Add any other context about the problem here.

Pull Requests All Pull Request should be made against development branch read contributors guide for more information about contributing