search

thenewinquiry / tni-core-functionality

Contains the site's core functionality.
GNU General Public License v2.0
2 stars 0 forks source link

Featured bundle keeps resetting after removal #46

Closed frnsys closed 6 years ago

frnsys commented 6 years ago

hey @misfist, we're trying to remove the featured post bundle. If we unset it in the Featured Content backend, it goes away, but for whatever reason, returns after some time. Any idea why this could be happening?

misfist commented 6 years ago

@frnsys - Sorry, this fell through the cracks.

If we unset it in the Featured Content backend, it goes away, but for whatever reason, returns after some time. Any idea why this could be happening?

I don't know why this would be.

When, I delete the bundle from the Featured Content option page, it's value becomes '' in the database. So, the condition to check for a bundle fails.

https://github.com/thenewinquiry/tni-core-functionality/blob/master/includes/helpers.php#L159-L195

Testing locally showed this to be working. However, I did notice that the option selector appeared to have a bundle value after clearing it. The DB had an empty value though.

I made a change to the field so that it doesn't appear to have a value after removing it.

misfist commented 6 years ago

@frnsys - Is this still an issue?

frnsys commented 6 years ago

nope this is all good now, thanks!