thenewinquiry / tni-core-functionality

Contains the site's core functionality.
GNU General Public License v2.0
2 stars 0 forks source link

Deploy updated plugin? #9

Closed frnsys closed 7 years ago

frnsys commented 7 years ago

hey Pea,

I updated the plugin to version 1.0.12 in composer.json but I'm not seeing my updates on the staging server after deploying them. Is there something else I need to do before those changes will be pulled?

misfist commented 7 years ago

There is no 1.0.12 tag in the repo. Versions need to be tagged in order for composer to be able to download them.

frnsys commented 7 years ago

I just tagged it and deployed to staging, but still doesn't seem like my changes took.

frnsys commented 7 years ago

Also I updated & tagged the theme but am having a similar issue.

misfist commented 7 years ago

Yes, I've been having similar issues intermittently, but am not sure why. I managed to get it updated to the latest versions by running again.

misfist commented 7 years ago

@emhoracek - this is the same deployment issue I was reporting. Updates to our theme and plugin (and sometimes other packages) aren't implemented on the server during deployment.

emhoracek commented 7 years ago

@misfist Thanks for tagging me. I'm on vacation this week but I'll try to research how exactly Ansible works -- with any luck, once I really understand that, I'll be able to look at our workflow and the configs and it'll be obvious what's going on. :crossed_fingers: 🍀

frnsys commented 7 years ago

I think I might have figured out what's going on. It seems that trellis doesn't run composer update...when I go into the server and run composer update in /srv/www/thenewinquiry.com/current, the plugin updates. Not sure why this isn't just part of the playbook :\

misfist commented 7 years ago

Yes, I found the same thing.

misfist commented 7 years ago

I had no problems today updating 3-rd party plugins and WordPress core on staging today. What I did was run composer update locally, then pushed composer.json and composer.lock to the repo. Then, I ran the deployment script.

frnsys commented 7 years ago

Ok great - so then I should setup my vagrant environment to use Trellis as well. I'll close this now