search

thenextweb / passgenerator

A Laravel package to create Apple Wallet passes.
GNU General Public License v3.0
258 stars 43 forks source link

Cleaned up code #5

Closed hipsterjazzbo closed 8 years ago

hipsterjazzbo commented 8 years ago

Hope it's not to presumptious, but I cleaned up the code to be PSR-2 + just a lot nicer. Not functional changes, just tidied it up.

Great package :)

j3j5 commented 8 years ago

To be honest, I prefer class properties and variables to be lowercase and underscore separated and, AFAIK that's not part of the PSR2 spec. It isn't a big deal and since you took the time to apply all these changes I'm merging it in.

Thanks for your effort!

hipsterjazzbo commented 8 years ago

Yeah you're right, method names are prescribed but properties are not in PSR-1/2. However camelCase is pretty conventional, particularly in Laravel. Thanks!

hipsterjazzbo commented 8 years ago

@j3j5 Reckon you could tag a release?