thenfour / digifujam

32 stars 1 forks source link

keyboard display notes get stuck when changing sample variation #245

Open thenfour opened 2 years ago

thenfour commented 2 years ago

related #199 steps to repro:

  1. select a sampled instrument with multiple variations (e.g. bass)
  2. hold a note, see the note in the keyboard indicator
  3. still holding the note, change instrument variations
  4. release note.

note will still be shown in keyboard indicator despite not playing it anymore.

i think we're missing handling an AllNotesOff somewhere.