search

thenickdude / chickenpaint

An HTML5 Port of the ChibiPaint multi-layer Oekaki painting tool
GNU General Public License v3.0
117 stars 21 forks source link

add missing icons #24

Closed blurymind closed 3 years ago

blurymind commented 3 years ago

This pr adds the missing icons (using ones from Gimp's similar set)

image

fixes https://github.com/thenickdude/chickenpaint/issues/6

thenickdude commented 3 years ago

I don't see any licensing information here

blurymind commented 3 years ago

it uses from gimp https://gitlab.gnome.org/GNOME/gimp/blob/master/icons/Symbolic/symbolic-scalable.svg

not sure what the license is, guessing its creative commons.

Werent the old ones taken from gimp as well? I imagine its the same

thenickdude commented 3 years ago

We cannot just steal icons without ensuring the license is compatible and that they are credited correctly.

blurymind commented 3 years ago

Would you be open to using them if I find you the license?

On Fri, 14 May 2021, 21:25 Nicholas Sherlock, @.***> wrote:

We cannot just steal icons without ensuring the license is compatible and that they are credited correctly.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/thenickdude/chickenpaint/pull/24#issuecomment-841482900, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABRRWVPSPF3VJD4KDDHW4R3TNWBNJANCNFSM445BHEUA .

thenickdude commented 3 years ago

No, I don't think any of these icons are great fits to be honest. They're less clear than the original text. e.g. water colour just looks like a generic paintbrush, a paint roller is not a blender, undo/redo look like rotation buttons, no way to understand that the 100% zoom button will zoom to 100% based on what the icon looks like, etc.

blurymind commented 3 years ago

Ah fair enough. I will try to find a better set and first pitch it before trying it in chickenpaint.

On Sat, 15 May 2021, 00:13 Nicholas Sherlock, @.***> wrote:

No, I don't think any of these icons are great fits to be honest. They're less clear than the original text. e.g. water colour just looks like a generic paintbrush, a paint roller is not a blender, undo/redo look like rotation buttons, no way to understand that the 100% zoom button will zoom to 100% based on what the icon looks like, etc.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/thenickdude/chickenpaint/pull/24#issuecomment-841544763, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABRRWVM4U6ZUC3TL2O4N4I3TNWVCJANCNFSM445BHEUA .