Add compatibility for packing with webpack

thenickdude / webm-writer-js

JavaScript-based WebM video encoder for Google Chrome

272 stars 43 forks source link

Add compatibility for packing with webpack #17

Closed HerrZatacke closed 2 years ago

HerrZatacke commented 4 years ago

This should fix issue https://github.com/thenickdude/webm-writer-js/issues/16

I ran your tests npm run test as well which did work for me, but these only cover the electron-side as far as I can see, so please check if the "plain" browser version works for you as well.

chrisgervang commented 2 years ago

Any chance this (or something that solves the same issue) can be merged in? I've also encountered the issue with next.js https://github.com/visgl/hubble.gl/issues/158

ilijapuaca commented 2 years ago

+1 for landing this in some capacity, we're stuck with the same issue when trying to make use of esbuild

chrisgervang commented 2 years ago

I linked this version of the library to the hubble.gl repo locally and ran the browser through some render tests. Great news! No runtime errors, and I was able to remove my webpack workaround. This seems like a great PR to merge and publish - much appreciated for putting it together @HerrZatacke, and thanks for your hard work @thenickdude!