thenickdude / webm-writer-js

JavaScript-based WebM video encoder for Google Chrome
272 stars 43 forks source link

Check if frameDuration is a number #38

Open KristjanESPERANTO opened 2 years ago

KristjanESPERANTO commented 2 years ago

I've taken value for frameDuration from a slider. As a result, I got super long videos even though they should only be seconds long. There was no error message, so it took me a while to find out that the value from the slider is a string and that I have to convert it to an integer first.

I thought about converting the value automatically via parsInt, but I like it better when the input values are checked and an error message is thrown out.