search

thenikso / angular-flexslider

AngularJS directive to use Woothemes' FlexSlider jQuery plugin.
MIT License
189 stars 100 forks source link

Specify explicit flexslider version #58

Open isellsoap opened 9 years ago

isellsoap commented 9 years ago

Since a few days ago FlexSlider has a bower.json and package.json, so one could replace "latest" with the appropriate version number. But there’s a problem: they set the jQuery dependency with the fixed version 1.11.3 which will break projects using jQuery 2.x (like this one). I opened an issue discussing this problem (also added a PR), maybe you could jump in and also raise your concerns. :-) Thanks!

hugomenesesp commented 9 years ago

When I used flexslider (not angular-flexlider) in my bower.json I was using "flexslider": "#version/2.5.0" and "jquery": "~2.1.4" with no compatibility issues. Now in flexslider they released a tag 2.5.0 (diferent from version/2.5.0) that explicit the version "1.11.3" which causes the conflict.

So, angular-flexslider should point to "version/2.5.0" or flexslider to an upper jQuery version.

isellsoap commented 9 years ago

Definitely the last one: flexslider should point to to >=1.11.3. Please comment on the appropriate issue I created to ask for it, too. Thanks!