thenikso / angular-inview

AngularJS directive to check if a DOM element is in the browser viewport.
http://thenikso.github.io/angular-inview/
MIT License
480 stars 112 forks source link

Incorrect version on npm #71

Closed svbatalov closed 8 years ago

svbatalov commented 9 years ago

Hi.

It seems the version 1.5.0 of angular-inview published on npm registry is actually something pre-1.3.3. I found that I can not minify my code because the array syntax is not used in controller declaration here:

 function inViewContainerDirective () {
  return {
    restrict: 'A',
    controller: function ($element) {
      this.element = $element;
      this.eventsSignal = signalFromEvent($element, 'scroll');
      this.getViewportRect = function () {
         return $element[0].getBoundingClientRect();
      };
    }
  }
}

This was fixed in v1.3.3.