thennothinghappened / GMEdit-Constructor

https://github.com/YAL-GMEdit/builder, but uses Igor!
MIT License
15 stars 2 forks source link

Paths passed to Igor are unquoted #10

Closed thennothinghappened closed 7 months ago

thennothinghappened commented 9 months ago

At the moment Constructor gives arguments to Igor without quoting the values, or escaping spaces... which is an issue if any project happens to have spaces in its file path.

Haven't tested if that actually causes any issues (Igor seems to parse arguments very strangely), but do know that what currently blocks this change is that Igor seems to refuse to launch when a runtime path is quoted.

craigtubb57 commented 9 months ago

Haven't tested if that actually causes any issues (Igor seems to parse arguments very strangely), but do know that what currently blocks this change is that Igor seems to refuse to launch when a runtime path is quoted.

Have you tried replacing the spaces with %20 instead? Perhaps that's what Igor prefers.

thennothinghappened commented 9 months ago

Possible? It'd be pretty weird though and I've never seen the IDE issue any commands using URL encoding...

Also, to keep you in the loop I've not had time to work on Constructor for a bit now thanks to school. I'll get back on it when I can but no guarantees.

craigtubb57 commented 9 months ago

Possible? It'd be pretty weird though and I've never seen the IDE issue any commands using URL encoding...

Also, to keep you in the loop I've not had time to work on Constructor for a bit now thanks to school. I'll get back on it when I can but no guarantees.

Thought it worth a go :) And no worries, school comes first!

thennothinghappened commented 7 months ago

After giving this another proper look (and fixing stderr not actually being read, which was probably making debugging harder in quite a few cases) I realised that Node's spawn actually already quotes what its given, so trying to add quotes was really just causing it to escape them, which in turn confused Igor. This is actually a non-issue!