search

thenosewizard / pe

0 stars 0 forks source link

Add client: Duplicates allowed in the application #2

Open thenosewizard opened 3 days ago

thenosewizard commented 3 days ago

Names with spacing is allowed in the application

Command to use:

  1. add n/John Doe p/98765432 e/johnd@example.com a/John street, block 123, #01-01

  2. add n/John Doe p/98765432 e/johnd@example.com a/John street, block 123, #01-01

"John Doe" in the second command has an extra space, However it is allowed in the application. The rest of the params are exactly the same

image.png

nus-se-script commented 5 hours ago

[IMPORTANT!: Please do not edit or reply to this comment using the GitHub UI. You can respond to it using CATcher during the next phase of the PE]

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

No checks for extra white spacing

image.png

"john doe" and "john doe" with extra spacing are both counted as different people, which might not be the best approach. (especially since their other fields are the same) Might be better to count both john doe's as the same person, especially if the user is typing fast, it is easy to make mistakes such as extra spacing.

[original: nus-cs2103-AY2425S1/pe-interim#3167] [original labels: severity.Medium type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Thanks for bringing this up, this will be accepted.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your reason]