[iOS Bootcamp] Review my App

[theo1985]

/cc @timothy1ee @thecodepath

http://s27.postimg.org/3pl2pu33l/Rotten_Tomatoes.gif

[theo1985]

I can't get the GIF to render in README, probably because of shitty hosting site. imgur kept failing on me, I think my WiFi is crapped out -- currently on HotSpot from phone

[stepan]

Hey Theofanis, Network error story is required. You need to complete it before I can grade the project. Comment here when you have completed this story.

[stepan]

:+1: nice work. The point of this homework was to explore a simple example of a full MVC application with a RESTful API. A few notes after checking out the code:

• Be sure to follow the Objective-C code styling conventions for the homework. The New York Times has a good summary of appropriate Objective-C coding conventions, you should take a quick look here.
• You should always try to minimize the number of properties and methods in the header files and move all private properties and methods into the class extension (the @interface block in the .m file).
• Nice work implementing the Movie model.
• Your custom Movie cell should have a property called movie. In the custom setter of movie, you should configure the various labels and images. This decouples your custom cells from the table view controllers.
• Nice work loading the images asynchronously but you should have used UIImageView category in the AFNetworking library.
• Note that your images are stretched. You should observe the UIContentMode of the UIImageView. By default, it will stretch the image to match your dimensions, which is probably not what you want.
• In general, you should challenge yourself to create visually polished applications. That's where you'll find all the rough edges of the iOS framework and earn the next level of mastery.

[theo1985]

Hi Stepan,

I assumed we couldn't commit changes after the deadline -- I will complete this now and commit

Also, generally speaking I try to get things working then iterate and organize the code as well as design. Unfortunately, I misjudged my time availability for particular project and didn't have time to come back and 'clean up'

Theo

On Sat, Jun 14, 2014 at 6:16 PM, Stepan Grigoryan notifications@github.com wrote:

[image: :+1:] nice work. The point of this homework was to explore a simple example of a full MVC application with a RESTful API. A few notes after checking out the code:

• Be sure to follow the Objective-C code styling conventions for the homework. The New York Times has a good summary of appropriate Objective-C coding conventions, you should take a quick look here https://github.com/NYTimes/objective-c-style-guide.
• You should always try to minimize the number of properties and methods in the header files and move all private properties and methods into the class extension (the @interface https://github.com/interface block in the .m file).
• Nice work implementing the Movie model.
• Your custom Movie cell should have a property called movie. In the custom setter of movie, you should configure the various labels and images. This decouples your custom cells from the table view controllers.
• Nice work loading the images asynchronously but you should have used UIImageView category in the AFNetworking library.
• Note that your images are stretched. You should observe the UIContentMode of the UIImageView. By default, it will stretch the image to match your dimensions, which is probably not what you want.
• In general, you should challenge yourself to create visually polished applications. That's where you'll find all the rough edges of the iOS framework and earn the next level of mastery.

— Reply to this email directly or view it on GitHub https://github.com/theo1985/RottenTomatoes/issues/1#issuecomment-46103976 .

[theo1985]

http://s17.postimg.org/xp8wzx73h/Rotten_Tomatoes.gif

[stepan]

Thanks for adding the missing feature. Next time, try to finish the required stories first before adding the optional ones.