theochem / AtomDB

An Extended Periodic Table of Neutral and Charged Atomic Species
http://atomdb.qcdevs.org/
GNU General Public License v3.0
16 stars 13 forks source link

Update GBasis API in compilation scripts #20

Closed gabrielasd closed 5 months ago

gabrielasd commented 8 months ago

This affects the datasets that rely on method using gaussian basis sets, the UHF (gaussian) and the HCI datasets.

Aditish51 commented 6 months ago

Hey, @gabrielasd I would like to try and solve this issue. Can you please provide me more details on it?

Ansh-Sarkar commented 6 months ago

Hi @gabrielasd . I ran into the same issue recently while I was working on adding the METADATA support to the available datasets. Have been working on it for a while : #15. There are a few libraries that I had to build from source, namely - gbasis, iodata, and grid. Also while building the sphinx documentation, the necessary theme dependencies were not present.

Proposed Solutions

gabrielasd commented 6 months ago

Hi @Ansh-Sarkar, I think both are very good ideas and great feedback. @msricher what do you think?

I'm not sure if a separate setup script or just adding a dev section to the configuration toml is the way to go here, though. At the very least we need to improve the documentation for installation instructions, which we will be working on soon.

msricher commented 6 months ago

I think just adding it to the toml file if good enough.

Ansh-Sarkar commented 6 months ago

Thank you @gabrielasd and @msricher . I agree that adding a [dev] section to the toml file would be a better idea. Will allow keeping all dependencies in a single file.

Also about the documentation for the installation instructions I was thinking we could maybe add a quickstart section to the Sphinx documentation as well as the project readme. Would love to work on that once #15 is taken care of. In fact, would love to hear your feedback regarding my current progress on #15 as well, whenever time permits. Thanks !

gabrielasd commented 5 months ago

This issue has been resolved in the current version on master.