theochem / Selector

Python library of algorithms for selecting diverse subsets of data for machine-learning.
https://selector.qcdevs.org
GNU General Public License v3.0
22 stars 22 forks source link

Add more similarity measurements, fixes #124 #188

Closed FanwangM closed 5 months ago

FanwangM commented 11 months ago

This PR addresses https://github.com/theochem/Selector/issues/124. The SimilarityIndex class was moved to similarity module to make things consistent, which is mainly for calculating similarity matrix. The smilarity.py in method module was renamed to sim.py because we have two similarity.py files, which can be very confusing. Actually I would perfer to use nsim.py, but to keep things consistent with other files name, I chose sim.py.

codecov[bot] commented 11 months ago

Codecov Report

Attention: Patch coverage is 97.62846% with 6 lines in your changes missing coverage. Please review.

Project coverage is 96.96%. Comparing base (0de2c9b) to head (d5cc58d). Report is 37 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/theochem/Selector/pull/188/graphs/tree.svg?width=650&height=150&src=pr&token=0UJixrJfNJ&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=theochem)](https://app.codecov.io/gh/theochem/Selector/pull/188?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=theochem) ```diff @@ Coverage Diff @@ ## main #188 +/- ## ========================================== - Coverage 97.57% 96.96% -0.61% ========================================== Files 9 9 Lines 907 924 +17 ========================================== + Hits 885 896 +11 - Misses 22 28 +6 ``` | [Files](https://app.codecov.io/gh/theochem/Selector/pull/188?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=theochem) | Coverage Δ | | |---|---|---| | [selector/methods/\_\_init\_\_.py](https://app.codecov.io/gh/theochem/Selector/pull/188?src=pr&el=tree&filepath=selector%2Fmethods%2F__init__.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=theochem#diff-c2VsZWN0b3IvbWV0aG9kcy9fX2luaXRfXy5weQ==) | `100.00% <100.00%> (ø)` | | | [selector/methods/sim.py](https://app.codecov.io/gh/theochem/Selector/pull/188?src=pr&el=tree&filepath=selector%2Fmethods%2Fsim.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=theochem#diff-c2VsZWN0b3IvbWV0aG9kcy9zaW0ucHk=) | `96.05% <96.05%> (ø)` | | | [selector/similarity.py](https://app.codecov.io/gh/theochem/Selector/pull/188?src=pr&el=tree&filepath=selector%2Fsimilarity.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=theochem#diff-c2VsZWN0b3Ivc2ltaWxhcml0eS5weQ==) | `98.61% <98.29%> (-1.39%)` | :arrow_down: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/theochem/Selector/pull/188/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=theochem)
FanwangM commented 5 months ago

I am going to close this PR as this has been addressed by