Open kunikachandra opened 4 months ago
@FanwangM can you take a look? Sorry for force pushing couple of times, had some pre-commit ci failures
Thanks for pushing this forward. I will look at it later. @kunikachandra
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 96.21%. Comparing base (
dbc2202
) to head (6cf18ff
). Report is 1 commits behind head on main.
@FanwangM should I create a new PR for setup.py
or commit in this PR only?
Also, should I change the name to qc-selector
instead of selector
for the pypi package because selector
is already taken by a previous project?
@FanwangM should I create a new PR for
setup.py
or commit in this PR only?Also, should I change the name to
qc-selector
instead ofselector
for the pypi package becauseselector
is already taken by a previous project?
You can keep adding new things into this PR. And we would prefer using the qc-selector
. @kunikachandra
Thanks for helping with this.
This PR will partially solve (the pypi part) issue #46. After this the
selector
package will be accessible via pypi pip.selector
orqc-selector
(pyproject.toml
line 26 needs to be changed toqc-selector
if we wantpip install qc-selector
to work).PYPI_API_TOKEN
and paste the API token.