theochem / Selector

Python library of algorithms for selecting diverse subsets of data for machine-learning.
https://selector.qcdevs.org
GNU General Public License v3.0
22 stars 22 forks source link

Clean up the distance function kwargs for `DISE` #269

Closed FanwangM closed 1 month ago

FanwangM commented 1 month ago

This PR removes the redundant kwargs for distances function as the user can always define it in the lambda function.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.37%. Comparing base (d080d9c) to head (f6ff079). Report is 1 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/theochem/Selector/pull/269/graphs/tree.svg?width=650&height=150&src=pr&token=0UJixrJfNJ&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=theochem)](https://app.codecov.io/gh/theochem/Selector/pull/269?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=theochem) ```diff @@ Coverage Diff @@ ## main #269 +/- ## ========================================== + Coverage 95.20% 95.37% +0.17% ========================================== Files 9 9 Lines 1022 1017 -5 ========================================== - Hits 973 970 -3 + Misses 49 47 -2 ``` | [Files with missing lines](https://app.codecov.io/gh/theochem/Selector/pull/269?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=theochem) | Coverage Δ | | |---|---|---| | [selector/methods/distance.py](https://app.codecov.io/gh/theochem/Selector/pull/269?src=pr&el=tree&filepath=selector%2Fmethods%2Fdistance.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=theochem#diff-c2VsZWN0b3IvbWV0aG9kcy9kaXN0YW5jZS5weQ==) | `97.45% <100.00%> (+1.15%)` | :arrow_up: |