theochem / cgrid

C++ version of horton (2.x) grid functionality
GNU General Public License v3.0
4 stars 1 forks source link

changed to download templating system #21

Closed matt-chan closed 7 years ago

codecov[bot] commented 7 years ago

Codecov Report

Merging #21 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #21   +/-   ##
=======================================
  Coverage   80.06%   80.06%           
=======================================
  Files           7        7           
  Lines         306      306           
  Branches       30       30           
=======================================
  Hits          245      245           
  Misses         57       57           
  Partials        4        4

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 61addad...a7218b4. Read the comment docs.

tovrstra commented 7 years ago

Looks good.

tovrstra commented 7 years ago

Is there a special reason to switch to the newer xcode? I've set it to the oldest on Travis-CI to have compatibility with all (supported) OSX versions.

matt-chan commented 7 years ago

oh! Hmm no, I just changed it for the sake of testing with the newest version. I can change it back. On Wed, 6 Sep 2017 at 13:57 Toon Verstraelen notifications@github.com wrote:

Is there a special reason to switch to the newer xcode? I've set it to the oldest on Travis-CI to have compatibility with all (supported) OSX versions.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/theochem/qcgrids/pull/21#issuecomment-327460942, or mute the thread https://github.com/notifications/unsubscribe-auth/AA_-NSvgOfpL4x_452DD9AKjiI2QmNTnks5sfoiqgaJpZM4PL9WN .

-- Matt

Sent from my phone

matt-chan commented 7 years ago

@tovrstra ready for review

tovrstra commented 7 years ago

Looks good!