Closed matt-chan closed 7 years ago
Looks good.
Is there a special reason to switch to the newer xcode? I've set it to the oldest on Travis-CI to have compatibility with all (supported) OSX versions.
oh! Hmm no, I just changed it for the sake of testing with the newest version. I can change it back. On Wed, 6 Sep 2017 at 13:57 Toon Verstraelen notifications@github.com wrote:
Is there a special reason to switch to the newer xcode? I've set it to the oldest on Travis-CI to have compatibility with all (supported) OSX versions.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/theochem/qcgrids/pull/21#issuecomment-327460942, or mute the thread https://github.com/notifications/unsubscribe-auth/AA_-NSvgOfpL4x_452DD9AKjiI2QmNTnks5sfoiqgaJpZM4PL9WN .
-- Matt
Sent from my phone
@tovrstra ready for review
Looks good!
Codecov Report
Continue to review full report at Codecov.