Closed tovrstra closed 6 years ago
Note: work in progress...
To do list:
@matt-chan @FarnazH This is a rather big and boring first step in qcgrids. These scalar functions are useful when defining radial grids and when building models of densities/potentials on radial grids. This is loosely based on similar code in horton.grid.rtransform.*
and horton.grid.cubic_spline.*
. The code is somewhat simplified and kept more general.
All was just rebased.
@tovrstra, I'm back in Canada now =)! Is this the complete code? or is it still missing the lines from before?
I think I found them. Have a good time home!
@matt-chan they are complete again. Seems to be working.
@matt-chan @FarnazH ping. would you still like to take a look in the near future? I'm fine either way. If not, I'll merge soon.
@tovrstra Thanks for your message. I will take a look at it on this weekend, but if you need to merge it earlier please feel free to do so.
No rush. I'm still occupied by plenty of other things.
No problem. Regarding the docstrings, functions in extension modules do not have function signatures by default. You either write them manually on the first line of the docstring or you can instruct Cython to do this for you. I'll enable that Cython option for now.
Sounds good! Thanks Toon!
On Mon, 23 Oct 2017 at 10:50 Toon Verstraelen notifications@github.com wrote:
No problem. Regarding the docstrings, functions in extension modules do not have function signatures by default. You either write them manually on the first line of the docstring or you can instruct Cython to do this for you. I'll enable that Cython option for now.
— You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/theochem/qcgrids/pull/22#issuecomment-338684297, or mute the thread https://github.com/notifications/unsubscribe-auth/AA_-Nc2ggw7h91pTG12nVZvqY6IskLsmks5svKefgaJpZM4PMn49 .
-- Matt
Sent from my phone
Small note: I fixed the issues with -Werror causing lots of troubles for the unit tests due to weird tricks used in gtest. Not our fault. -Werror is only disabled for the unit tests, not for the rest of the code.
Codecov Report
100% <100%> (ø)
100% <100%> (ø)
100% <100%> (ø)
56.52% <70.39%> (+32.52%)
71.87% <71.87%> (ø)
99.45% <99.45%> (ø)
Continue to review full report at Codecov.