search

theochem / cgrid

C++ version of horton (2.x) grid functionality
GNU General Public License v3.0
4 stars 1 forks source link

added conda-build3 #28

Closed matt-chan closed 6 years ago

codecov[bot] commented 6 years ago

Codecov Report

Merging #28 into master will increase coverage by 0.59%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #28      +/-   ##
==========================================
+ Coverage   80.06%   80.65%   +0.59%     
==========================================
  Files           7        7              
  Lines         306      305       -1     
  Branches       30       30              
==========================================
+ Hits          245      246       +1     
  Misses         57       57              
+ Partials        4        2       -2
Impacted Files Coverage Δ
qcgrids/cellgrid.cpp 95.12% <0%> (-0.12%) :arrow_down:
qcgrids/tests/test_supergrid.cpp 100% <0%> (+1.24%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ac5d1e2...e0d2ffa. Read the comment docs.

matt-chan commented 6 years ago

@tovrstra Ready for review. I think this should work well now. Sorry for all the version churn...

We should add Py3 to this, but we can do that after this is merged in. Also, I'm not a huge fan of all the different build paths (tagged, not tagged, PR). There's a lot to debug because of it. Also, it means that a PR that passes might not build on release. But maybe we should keep it for now because we're probably using all those build paths in the real development (we won't always build with conda-build I think?). We'll have to remember to tag PR builds to test conda builds.

Also, I changed the build tags to be consistent with conda's documentation (dev/test/main instead of alpha/beta/main).

I also updated the template.py script to include an option for templating from a local file. That way we can apply travis scripts that haven't been merged to master yet (like this one).

Things that we should still do, but probably in another PR/later:

tovrstra commented 6 years ago

@matt-chan This is already a great improvement! Really, thanks for the nice work! I only have a few minor comments and I agree the remaining points are better handled in separate PRs.

tovrstra commented 6 years ago

@matt-chan Looks good. I'll check tomorrow that tests passed and merge but feel free to merge before I get to it.