Closed FarnazH closed 3 years ago
You are right. It should just call AtomGrid.from_pruned
to construct the instance. I think I wrote that code just to double check the result are consistent between the two methods incase errors or bugs in one or the other.
We still support the same grid defined in HT2 as long as the radial is provided by the user. When I design grid, I believe, the new radial grids we implemented gonna perform better than the old power
or exp
radial. So it's less meaningful to offer an inferior default choice.
Pruned grids should have a specified number of radial points for each atom; the specific choice of radial grid and transformation should be user-specified, though one could argue for using the same default as is usually done.
So
@FarnazH Could you update the black style so I can merge the commit asap
Merging #115 (0022aa2) into master (a2bb522) will not change coverage. The diff coverage is
100.00%
.
@@ Coverage Diff @@
## master #115 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 14 14
Lines 1389 1389
=========================================
Hits 1389 1389
Impacted Files | Coverage Δ | |
---|---|---|
src/grid/molgrid.py | 100.00% <ø> (ø) |
|
src/grid/atomgrid.py | 100.00% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update a2bb522...0022aa2. Read the comment docs.
The current changes update the docstrings of
AtomGrid
to make them complete and consistent. In addition, a few argument names are changes to add clarity. Before making any further changes, I wanted to clarify a few things regarding theAtomGrid
constructors which are exemplifiedd below:AtomGrid.from_predefined
loaded precomputedsectors_r
§ors_size
, shouldn't it just callAtomGrid.from_pruned
upon loading the sectors information? This is not howAtomGrid.from_predefined
is currently implemented. So, I am a bit confused.HORTON2
, thecoarse
built-in grid specifies the radial grid points as well. See: http://theochem.github.io/horton/2.1.1/tech_ref_grids.html?highlight=insane This is not the case forAtomGrid
, so how are we going to supportHORTOn2
-type built-in grids?Any comments are welcomed @tczorro, @tovrstra, and @PaulWAyers.