theochem / grid

Python library for numerical integration, interpolation, and differentiation on (molecular) grids.
https://grid.qcdevs.org/
GNU Lesser General Public License v3.0
46 stars 19 forks source link

[added] alvarez covalent radii #160

Closed marco-2023 closed 1 year ago

marco-2023 commented 1 year ago

Added the covalent radii database from: B. Cordero,.V. Gómez, A. E. Platero-Prats, M. Revés,J. Echeverría, E. Cremades, F Barragána, S. Alvarez, Dalton Trans., 2008, 2832-2838 https://doi.org/10.1039/B801115J

Observations:

Ali-Tehrani commented 1 year ago

Thank you for this pull request. I added a test and fixed some issues.

FarnazH commented 1 year ago

@Ali-Tehrani, I noticed your commit message that "Based on my previous results they didn't match my results up to 4 decimal places, probably based on the conversion factor from angstrom to bohr." Can you please share how you got your numbers? If you have a code snippet, please share.

Ali-Tehrani commented 1 year ago

Sure, the code snippet is here.

I took the radius values from Table 2 in the paper and converted them to Bohr using the same conversion factor that was used in the previous tests.

FarnazH commented 1 year ago

Thanks, @Ali-Tehrani. Your conversion factor is the same as iodata, see:

>>> from iodata.utils import angstrom
>>> angstrom
1.8897261246257702
>>> angstrom - 1.8897261339213
-9.295529901365285e-09

@marco-2023, what conversion factor were you using? I just want to make sure that was the reason your numbers were different from Ali's.

marco-2023 commented 1 year ago

@FarnazH I revised the numbers. The numbers were different because I used 1.88973 as the conversion constant (not the one in iodata). I also made a mistake parsing the results in order to add the underscores. Sorry for that. It won't happen again.

FarnazH commented 1 year ago

No worries @marco-2023. I just wanted to make sure we understand what was happening. We all make mistakes, and that's why we have code reviews :-) Thanks for your contribution.