theochem / horton

HORTON: Helpful Open-source Research TOol for N-fermion systems
http://theochem.github.io/horton/
GNU General Public License v3.0
92 stars 40 forks source link

Fix workaround cython 0.24 #207

Closed tovrstra closed 7 years ago

tovrstra commented 7 years ago

This change makes the gbasis extension compile with Cython 0.24. The problem is a silly bug in Cython 0.24, which got fixed in 0.24.1. However, 0.24 seems to be widespread, so this small change seems reasonable to facilitate compilation for users that cannot easily upgrade Cython.

tovrstra commented 7 years ago

P.S. I'm still testing this on the machine where I'm stuck with Cython 0.24.

tovrstra commented 7 years ago

@matt: this should be good to merge now. Can you take a quick look?

matt-chan commented 7 years ago

Looks good to me! Sorry for the late reply. Still drowning in teaching =S

I think Clifford was restarted and didn't run the agents again. I'll take a look on our end. But maybe in the long run we should have something more permanent.

Matt