Closed crisely09 closed 7 years ago
Looks a lot better. Can you fix the following problems?
Add basis/aug-cc-pv5z.nwchem
and basis/aug-cc-pv6z.nwchem
Replace the tab in ints.h
in the first commit by four spaces (requires rewrite).
Thanks!
hmm I swear I changed line 80 of ints.h, wait, in the first commit?
Sorry for the late reply. Yep, the first commit still has the tab. You need to squash the commit that fixes it into the commit that has adds the tab.
This time seems that the problem was the documentation... how can I fix it?
I also ran into that problem today. This is fixed in the PR I just made. See #229. You can make use of this by rebasing onto master after the other PR gets merged.
@crisely09 it's fixed. Can you rebase your PR please? Thanks!
Oh, I see all the format and documentation problems, I'll fix them.
A rebase on the latest master commit should fix most problems.
There is still some cleaning left to do. I'll mark everything...
P.S. I'll just point out the essential ones to get the tests passing...
P.S. Can you also just add commits (rather than squashing). That would make reviewing easier. Thanks!
Alright, seems that all passed now.
Looks good! I'll let you merge Toon. Thanks Cris!
Done.
Great! Merging...
Trying once more.