theochem / horton

HORTON: Helpful Open-source Research TOol for N-fermion systems
http://theochem.github.io/horton/
GNU General Public License v3.0
92 stars 40 forks source link

Modified naints #213

Closed crisely09 closed 7 years ago

crisely09 commented 7 years ago

Trying once more.

tovrstra commented 7 years ago

Looks a lot better. Can you fix the following problems?

Thanks!

crisely09 commented 7 years ago

hmm I swear I changed line 80 of ints.h, wait, in the first commit?

tovrstra commented 7 years ago

Sorry for the late reply. Yep, the first commit still has the tab. You need to squash the commit that fixes it into the commit that has adds the tab.

crisely09 commented 7 years ago

This time seems that the problem was the documentation... how can I fix it?

tovrstra commented 7 years ago

I also ran into that problem today. This is fixed in the PR I just made. See #229. You can make use of this by rebasing onto master after the other PR gets merged.

matt-chan commented 7 years ago

@crisely09 it's fixed. Can you rebase your PR please? Thanks!

crisely09 commented 7 years ago

Oh, I see all the format and documentation problems, I'll fix them.

tovrstra commented 7 years ago

A rebase on the latest master commit should fix most problems.

tovrstra commented 7 years ago

There is still some cleaning left to do. I'll mark everything...

tovrstra commented 7 years ago

P.S. I'll just point out the essential ones to get the tests passing...

tovrstra commented 7 years ago

P.S. Can you also just add commits (rather than squashing). That would make reviewing easier. Thanks!

crisely09 commented 7 years ago

Alright, seems that all passed now.

matt-chan commented 7 years ago

Looks good! I'll let you merge Toon. Thanks Cris!

crisely09 commented 7 years ago

Done.

tovrstra commented 7 years ago

Great! Merging...