Closed tovrstra closed 2 months ago
Here's the code health analysis summary for commits 22475e1..d3fbc2b
. View details on DeepSource ↗.
Analyzer | Status | Summary | Link |
---|---|---|---|
Shell | ✅ Success | View Check ↗ | |
Python | ✅ Success | View Check ↗ |
💡 If you’re a repository administrator, you can configure the quality gates from the settings.
This pull request addresses a type checking issue by replacing TextIO
with TextIOBase
in the iodata/utils.py
file. Additionally, a new test function test_mixed_pure_cartesian
has been added to iodata/test/test_molden.py
to validate the handling of mixed pure Cartesian data.
Files | Changes |
---|---|
iodata/test/test_molden.py iodata/utils.py |
Added a new test case in test_molden.py and fixed type checking by replacing TextIO with TextIOBase in utils.py . |
Thanks for checking, Paul!
This fixes one aspect of #367, includes test.
As far as I understand, type hints should still use
TextIO
from the typing module, so I'm not changing these.Summary by Sourcery
This pull request fixes a type checking issue by replacing
TextIO
withTextIOBase
in the_interpret_file_lineno
function and adds a new test to verify the handling of mixed pure Cartesian data.TextIO
withTextIOBase
in the_interpret_file_lineno
function.test_mixed_pure_cartesian
to verify the handling of mixed pure Cartesian data in themolden_dump_one
function.