Closed tovrstra closed 2 months ago
This pull request introduces a new command-line option --allow-changes
to the iodata-convert
script, allowing users to permit data reorganization to ensure compatibility with the output format. The convert
function and associated tests have been updated to support and verify this new functionality.
Files | Changes |
---|---|
iodata/test/test_cli.py iodata/__main__.py |
Introduced and integrated the --allow-changes command-line option, updated the convert function to handle this new parameter, and added corresponding unit tests. |
Here's the code health analysis summary for commits 4dceda6..0a4d979
. View details on DeepSource ↗.
Analyzer | Status | Summary | Link |
---|---|---|---|
Shell | ✅ Success | View Check ↗ | |
Python | ✅ Success | View Check ↗ |
💡 If you’re a repository administrator, you can configure the quality gates from the settings.
Thanks for the quick check. I'm going to fix that and follow one of its suggestions for unit tests. Sourcery sometimes has a good idea of what still needs testing, but actual code changes still require some human oversight. (Or I am too picky.)
@sourcery-ai review
It's indeed good at catching spelling mistakes. :) Even if not all the AI comments are spot on, it just makes you rethink things, which is also helpful.
This addresses one of the steps of #191. The
iodata-convert
script gets an option to decide whether a (not trivially reversible) conversion of data should raise an error (default) or a warning (with the option). The default is not error when there is data degradation, out of an abundance of caution.Summary by Sourcery
This pull request introduces a new command-line option
--allow-changes
to theiodata-convert
script, allowing users to permit non-trivially reversible data conversions with warnings. Theconvert
function has been updated to support this new option, and corresponding unit tests have been added to ensure its correct functionality.--allow-changes
to theiodata-convert
script, allowing users to permit non-trivially reversible conversions with warnings instead of errors.convert
function to handle the newallow_changes
parameter, enabling conditional data modification for compatibility with the output format.--allow-changes
option, including scenarios where data degradation is allowed and where it raises errors.