Open FanwangM opened 2 years ago
Yeah I will fix this
It's weird how the issue doesn't exist at all for python3.8+ as well as python3.6-.
It's weird how the issue doesn't exist at all for python3.8+ as well as python3.6-.
True. I think it's Windows OS related only as I have tested for many times.
Anyways I think #191 fixes it?
I have tested it again on a windows machine with the same working environment (Python 3.7.9 and the same numpy and scipy version) and it works. Also, the current running of tests, https://github.com/theochem/procrustes/runs/8197877947?check_suite_focus=true, works. So, I would guess that's related to the hardware?
What do you think? @PaulWAyers @banrovegrie
Seems strange, but not implausible, to me. I guess we can specify the hardware in the install?
Maybe, but will that lead to a precision issue as big as 3 decimal places?
Let's have a meet and fix the currently present testing issues. Will anytime on the 10th of October (or later) work?
What's the time difference between us now (your current location and Toronto)? @banrovegrie
I got back to college yesterday. So now the time gap is around 9 hours. But I will mostly be available till late at night (India time) which should be around 3:30 PM Toronto time.
@FanwangM any updates?
Can you check why the testing is failing for https://github.com/theochem/procrustes/runs/8172507556?check_suite_focus=true? I have tried to rerun the testing and it didn't help. I don't know if it's
Scipy
orNumpy
version related or operating system related. The tests work before we merge the PR.Thank you. @banrovegrie