search

theodi / comma-chameleon

A desktop CSV editor for data publishers
https://comma-chameleon.io/
MIT License
278 stars 27 forks source link

move dependency management to yarn #163

Closed chris48s closed 3 years ago

chris48s commented 7 years ago

Closes #158

quadrophobiac commented 7 years ago

Hi @chris48s - I'd like to do a bit more research on how stable yarn is before merging this into master. My sense is that there are pros (bye bower, npm scripts) and cons (several [admittedly closed] issues that make me wary of how it might impact packaging apps cross platform) There's some moving parts in play in terms of how this codebase will be maintained in the near to long term. I'll leave this PR open pending that research's outcomes Thanks for doing the necessary work, especially on readme updates appreciate the thoroughness

chris48s commented 7 years ago

Yep no probs. It is there if you want it :)

bye bower

As I understand it, yarn used to be able to manage both npm and bower dependencies but they dropped support for bower. See https://github.com/yarnpkg/yarn/pull/1441 and the note at the top of https://bower.io/blog/2016/using-bower-with-yarn/ so I think being able to do away with bower is no longer an advantage of yarn. That's why I left the dependencies split between the 2 package managers in this PR.