search

theodi / comma-chameleon

A desktop CSV editor for data publishers
https://comma-chameleon.io/
MIT License
280 stars 27 forks source link

Publish to Github Not Functional? #178

Open quadrophobiac opened 7 years ago

quadrophobiac commented 7 years ago

Expected Behaviour

I'm not certain what should happen - @pezholio any insight?

Current Behaviour (for problems)

Neither of the github features from the menu are functional

Steps to Reproduce (for problems)

Your Environment

Include as many relevant details about the environment you experienced the bug in - this will help us resolve the bug more expediently

  • Operating System and version MacOS

The branch that has incorporated (StandardJS)[https://github.com/theodi/comma-chameleon/pull/177] has flagged this file with errors as follows

  121:11  error  Unexpected literal in error position of callback  standard/no-callback-literal
  125:9   error  Unexpected literal in error position of callback  standard/no-callback-literal
quadrophobiac commented 7 years ago

@pezholio realised you may not get a ping when I edit an existing comment so pinging anew here

pezholio commented 7 years ago

Huh. That's weird. I get a new window that prompts me to login to Github, but when I try to submit a file, I get Dataset files is invalid. Were any changes made to the Octopub API since the FSA work was done in the new year?

I haven't got time at the mo to dig into this, but if it helps, the relevant backend code that talks to the Octopub API is here

Sidebar: When logging into Github to get my token, and trying to copy and paste my Github password from my password manager, I get this error.

Uncaught Exception:
ReferenceError: mainWindow is not defined
    at exports.menu.submenu.click (/Applications/Comma Chameleon.app/Contents/Resources/app/main/menu.js:187:11)
    at MenuItem.click (/Applications/Comma Chameleon.app/Contents/Resources/electron.asar/browser/api/menu-item.js:81:16)
    at Function.delegate.executeCommand (/Applications/Comma Chameleon.app/Contents/Resources/electron.asar/browser/api/menu.js:119:40)
chris48s commented 7 years ago

@pezholio - that issue should have been fixed in f21beb4

If you're using a binary dist, I think that commit hasn't made it into a tagged release yet.

If you're running from source, make sure you've got the latest commits fetched/pulled, although @quadrophobiac has been having some problems with that so I'd be interested to know if you have the same issues.

Floppy commented 7 years ago

API shouldn't have changed, no. We should re-test with the current master and tag a release.

quadrophobiac commented 7 years ago

re-test Comma Chameleon you mean?

Floppy commented 7 years ago

Yep

quadrophobiac commented 7 years ago

I've tried running the tests on Master. They all pass but my issue with an empty window is still present. @pezholio or @chris48s could you see if the tests pass but the functionality continues to be absent?

chris48s commented 7 years ago

Yes - I've got the same problem. Tests pass, 'Export to GitHub' gives me a blank window with no errors logged to the console.

There's definitely something odd going on here though. Lets go back in time to a point where I know this feature definitely worked...

If I download the binary dist for say version 0.4.7, that feature does work .. but then on my local copy, if I git checkout af7f60e ( af7f60e is the commit tagged as 0.4.7), I've got the same problem on my working copy. I think whatever is going on is going to be related to something that is happening in the build process or a dependency or a setting that is on in dev but not when we build a release or something like that.. I don't think the actual "export to GitHub" code is fundamentally broken.

Sorry I don't have more time to spend on it right now but maybe that gives you a clue?