search

theodi / comma-chameleon

A desktop CSV editor for data publishers
https://comma-chameleon.io/
MIT License
280 stars 27 forks source link

JS error on Edit menu use #188

Open jeremydouglass opened 7 years ago

jeremydouglass commented 7 years ago

Expected Behaviour

Menu items in Edit menu -- e.g. to insert or remove columns or rows -- will function.

Current Behaviour (for problems)

Using insert column at any time on a fresh install fails with a JavaScript error.

This renders the program unusable unless working with exactly 3 columns of data.

Steps to Reproduce (for problems)

  1. download Comma.Chameleon-darwin-x64.zip from comma-chameleon.io
  2. unzip and drag Comma Chameleon.app to /Applications on macOS Sierra 10.12.6
  3. run
  4. select Edit > Insert Column Right (or Left)

Result:

A JavaScript error occurred in the main process
Uncaught Exception: ReferenceError: mainWindow is not defined at exports.menu.submenu.click (/Applications/Comma Chameleon.app/Contents/Resources/app/main/menu.js:228:11) at MenuItem.click (/Applications/Comma Chameleon.app/Contents/Resources/electron.asar/browser/api/menu-item.js:81:16) at Function.delegate.executeCommand (/Applications/Comma Chameleon.app/Contents/Resources/electron.asar/browser/api/menu.js:119:40)

Your Environment

This same error also appears with any item in the Edit menu -- insert / remove / column / row, undo / redo, cut / copy / select all etc. All pop up a javascript error dialog.

Stephen-Gates commented 7 years ago

@jeremydouglass as a work around, right click in a cell to display a context menu that allows you to add/delete rows/columns

jeremydouglass commented 7 years ago

Thank you, @Stephen-Gates -- that worked.

I have updated the issue to reflect that it is using any entry in the Edit menu that causes this popup error -- not just insert / remove column. All entries in the right-click dialog work correctly.

chameroy commented 6 years ago

I would like to add that this also occurs on Windows 10 using the 64-bit version.

jeremydouglass commented 6 years ago

Looks like, with the recent README update

Developed by the ODI as a proof of concept, it has now been replaced by Data Curator.

...this repo is deprecated and development has moved on to:

https://github.com/ODIQueensland/data-curator

...so this issue will probably not be resolved here....