theodi / member-directory

The ODI's member directory frontend application
MIT License
2 stars 1 forks source link

100% discounted invoices #374

Closed alisonwalters closed 9 years ago

alisonwalters commented 9 years ago

Hi We have received an invoice via Chargify / Stripe regarding an individual membership for Joe Pakenham. THis is showing in Xero as £108, but is discounted in Chargify by 100%. Chargify is correct, but it isn't translating correctly to Xero.

thx

pkqk commented 9 years ago

@alisonwalters as far as I understand it @greenreveller was going to leave invoices on in Stripe until we'd confirmed it was all working and then get @Floppy to disable the Xero invoice creation as it is entirely separate and they're only draft invoices.

Is this correct?

greenreveller commented 9 years ago

@pkqk That's on hold for now as Louise is talking to auditors about requirements for invoices.

So we still want invoices on but the issue is that invoice aren't creating properly in Xero (e.g. they are not reflecting the discounts on membership when the invoice is being created. So the revenue figures are being calculated incorrectly in Xero).

jordelver commented 9 years ago

This is now fixed @greenreveller :smile: The invoices in Xero are now correct.

If you could test and close that would be great :+1:

greenreveller commented 9 years ago

Just tested using coupon MENTOR (which gives 100% discount) but the is showing up without discount applied: image

Individual Supporter 100% discount 20/08 andrea.cox+test100discount@theodi.org Andrea Discount 3 Key Lane London UK G7 4RR (then I have used my actual billing address)

jordelver commented 9 years ago

I think I know what's wrong with this. I'm not sure how it slipped through though :( If you use &coupon=MENTOR in the querystring, it works. I'm looking at how to fix now.

greenreveller commented 9 years ago

ah, I applied the coupon directly on to the chargify page not using the querystring.

Needs to work in both instances

jordelver commented 9 years ago

I should have fixed this in https://github.com/theodi/member-directory/pull/467

jordelver commented 9 years ago

This is ready to be tested again @greenreveller once the styling issues are sorted

greenreveller commented 9 years ago

Successful test for Individual Supporter using 100% discount code MENTOR: Correct Payment Page data Welcome Email generated Capsule entry created Invoice correct in Xero Chargify entry created

ODI Individual supporter (KU3008MN) [Individual](card payment) image

greenreveller commented 9 years ago

I also tested for SMEs with 100% discount (coupon code: STARTUP using querystring https://directory.theodi.org/members/new?level=supporter&coupon=ODISTARTUP) but when I go through to Chargify payment page the coupon is not being applied. This may be a separate issue entirely?

jordelver commented 9 years ago

I had a quick look and I can't see why it wouldn't work. This probably is a separate issue.